http-service: add StopBackup&StopRestore api for http-service #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5374 +/- ##
==========================================
+ Coverage 61.56% 61.57% +0.01%
==========================================
Files 228 228
Lines 28866 28866
==========================================
+ Hits 17771 17775 +4
+ Misses 9349 9347 -2
+ Partials 1746 1744 -2
|
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
csuzhangxc
reviewed
Nov 14, 2023
cmd/http-service/server/backup.go
Outdated
Comment on lines
519
to
526
| // update backup status | ||
| _, err = opCli.PingcapV1alpha1().Backups(req.ClusterId).Update(ctx, backup, metav1.UpdateOptions{}) | ||
| if err != nil { | ||
| logger.Error("Backup not found", zap.Error(err)) | ||
| message := fmt.Sprintf("Backup %s not found", req.BackupId) | ||
| setResponseStatusCodes(ctx, http.StatusBadRequest) | ||
| return &api.StopBackupResp{Success: false, Message: &message}, nil | ||
| } |
There was a problem hiding this comment.
Can we remove these lines? and also for // update restore status
Signed-off-by: husharp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
example for backup:
add backup, status is Scheduled
return success
after backup, status is Stopped
when curl stop again, will return
Backup demo1-full-backup-s3 is already StoppedWhat is changed and how does it work?
Code changes
Tests
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.