Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: extend throttling backoff #5370

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Nov 2, 2023

What problem does this PR solve?

Close #5368
VolumeRestore CR WarmupStarted status not synced
Close #5369
Size calculation throttling backoff extension

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge November 2, 2023 13:33
@BornChanger BornChanger requested review from WangLe1321 and removed request for shonge and lichunzhu November 2, 2023 13:33
@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 2, 2023
Signed-off-by: BornChanger <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/XS labels Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #5370 (5f5297e) into master (a076c0e) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5370      +/-   ##
==========================================
- Coverage   61.60%   61.58%   -0.03%     
==========================================
  Files         228      228              
  Lines       28864    28879      +15     
==========================================
+ Hits        17782    17785       +3     
- Misses       9340     9349       +9     
- Partials     1742     1745       +3     
Flag Coverage Δ
unittest 61.58% <33.33%> (-0.03%) ⬇️

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

/cc @YuJuncen

@ti-chi-bot ti-chi-bot bot requested a review from YuJuncen November 2, 2023 18:36
@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-across-kubernetes

Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the lgtm label Nov 13, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-13 08:01:15.139972121 +0000 UTC m=+4063272.727082267: ☑️ agreed by WangLe1321.
  • 2023-11-13 08:08:58.173221207 +0000 UTC m=+4063735.760331352: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

New changes are detected. LGTM label has been removed.

@BornChanger
Copy link
Contributor Author

/run-test

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind

@csuzhangxc csuzhangxc merged commit 3a70782 into pingcap:master Nov 13, 2023
4 checks passed
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5390.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request could not be created: failed to create pull request against pingcap/tidb-operator#release-1.5 from head ti-chi-bot:cherry-pick-5370-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-5370-to-release-1.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: volumebackup failed calculating snapshot size ebs br: volumerestore status is not accurate
5 participants