add max retry

pingcap · Jan 7, 2025 · 6e12192 · 6e12192
1 parent 8fc3da2
commit 6e12192
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/controller/compactbackup/compact_backup_controller.go b/pkg/controller/compactbackup/compact_backup_controller.go
@@ -539,8 +539,11 @@ func (c *Controller) allowCompact(compact *v1alpha1.CompactBackup) bool {
 	}
 
 	attempts := len(compact.Status.RetryStatus)
-	if attempts > 0 && attempts <= int(compact.Spec.MaxRetryTimes) {
+	if attempts > 0 {
 		lastRetry := compact.Status.RetryStatus[attempts-1]
+		if lastRetry.RetryNum >= int(compact.Spec.MaxRetryTimes) {
+			return false
+		}
 		backoff := expBackoff(attempts)
 		if time.Since(lastRetry.DetectFailedAt.Time) < backoff {
 			klog.Infof("Compact: [%s/%s] backoff in effect, skipping retry.", ns, name)