add my-tester support for cascades planner. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arenatlx <[email protected]>
|
|
hawkingrei
reviewed
Jan 7, 2025
| @@ -39,13 +39,22 @@ Usage of ./mysql-tester: | |||
| The user for connecting to the database. (default "root") | |||
There was a problem hiding this comment.
Do you want to change this function to a custom suffix? This will make it look more universal?
There was a problem hiding this comment.
one day, when we remove the cascades planner switch (remove the old planner), we could just run cmd as below:
./mysql-tester -cascades=1 -check-error=1 -record=1 -cascades-suffix="result"
which will overrides test result of .result file, then we can remove all .casult files if any with find . -type -f -name "*.casult" | xargs rm
There was a problem hiding this comment.
cascades enable is out of tester now, when cascades is enabled, we will pass suffix as ".casult" in.
Signed-off-by: arenatlx <[email protected]>
Signed-off-by: arenatlx <[email protected]>
hawkingrei
approved these changes
Jan 8, 2025
Defined2014
reviewed
Jan 8, 2025
Defined2014
approved these changes
Jan 8, 2025
Signed-off-by: arenatlx <[email protected]>
bb7133
reviewed
Jan 8, 2025
bb7133
reviewed
Jan 8, 2025
bb7133
reviewed
Jan 8, 2025
Signed-off-by: arenatlx <[email protected]>
Signed-off-by: arenatlx <[email protected]>
Signed-off-by: arenatlx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add my-tester support for cascades planner.
for consequent usage of my-tester, we plan to make the ci env run for 2 time of current ut cases respectively for cascades planner and normal planner. For the first beginning of this two, since currently this two mode are compatible, the result between
.resultand.casultare almost same because no cascades rules are added now. With the rules' adding, the plan explain diff will occur but execution result should always keep the same as before. We introduce this for the sake of evolution of both planner at the same time for all test cases.