Add ext full backup #1281
Add ext full backup #1281
Conversation
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
This reverts commit a51d008. Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
…ext-full-bkup Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
…ext-full-bkup Signed-off-by: hillium <[email protected]>
proto/brpb.proto
Outdated
| @@ -898,6 +898,48 @@ message MetaEdit { | |||
| bool destruct_self = 4; | |||
| } | |||
|
|
|||
| // RewrittenTableID records a sort of modification over the SSTs during restoring. | |||
| // | |||
| // When "backing up" this "restored" SST, we want to backup what it was "restored". | |||
There was a problem hiding this comment.
I feel like we want to back up the original SST before any rewrite maybe more intuitive?
proto/brpb.proto
Outdated
| // `backup_uuid`. | ||
| bool finished = 5; | ||
| // When checkpoint enabled, one restoration may be | ||
| // sperated to many of `ExtraFullBackup`s. |
proto/brpb.proto
Outdated
|
|
||
| // ExtraFullBackup is created by BR restoring to a cluster with PITR enabled. | ||
| // This is uploaded by the BR CLI. | ||
| message ExtraFullBackup { |
There was a problem hiding this comment.
What do you think of the name LogBackupInjestedSST or other similar options.
I feel like in our code base there are a lot vague terms and we need to remember what they mean when reading the code, making a bit hard to understand. I personally like to name as explicit as possible. Let me know your thoughts.
Feel free to ignore the comment if you think otherwise!
|
@Tristan1900: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger, Tristan1900 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
No description provided.