[DNM] rename resolved_ts to watermark#1237
[DNM] rename resolved_ts to watermark#1237zhangjinpeng87 wants to merge 2 commits intopingcap:masterfrom
Conversation
Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com>
Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@wuhuizuo: Please do not delete or edit you lgtm type comment! DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of tikv/tikv#16708
resolved_tsto namewatermarkif it is a field. Rename proto filed name without change its id is compatible.rpc ReportMinResolvedTS(ReportMinResolvedTsRequest) returns (ReportMinResolvedTsResponse) {}for compatibility reason, at the same time addrpc ReportMinWatermark(ReportMinWatermarkRequest) returns (ReportMinWatermarkResponse) {}which will replace the former one in the future.