Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #21819

…worker_cnt

First-time contributors' checklist

Update system-variables tidb_ddl_reorg_batch_size and tidb_ddl_reorg_worker_cnt

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Sep 24, 2025
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for two critical system variables, tidb_ddl_reorg_batch_size and tidb_ddl_reorg_worker_cnt. The primary purpose of these updates is to inform users about the newly introduced capability in TiDB v8.5.0 to dynamically alter these parameters for DDL jobs that are already in progress. This enhancement provides database administrators with more flexibility to manage and optimize the performance of DDL operations without needing to restart or cancel ongoing tasks.

Highlights

  • Dynamic DDL Reorganization Batch Size: Documentation has been updated to reflect that, starting from TiDB v8.5.0, the tidb_ddl_reorg_batch_size system variable can be dynamically modified for a running DDL job using the ADMIN ALTER DDL JOBS command. This provides greater control over DDL performance during execution.
  • Dynamic DDL Reorganization Worker Count: The documentation for tidb_ddl_reorg_worker_cnt has been updated to indicate that, as of TiDB v8.5.0, this parameter can also be adjusted for active DDL jobs via the ADMIN ALTER DDL JOBS command, allowing for on-the-fly tuning of DDL concurrency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the tidb_ddl_reorg_batch_size and tidb_ddl_reorg_worker_cnt system variables. The changes add information about the new capability in v8.5.0 to modify these parameters for running DDL jobs using the ADMIN ALTER DDL JOBS statement. My review provides minor suggestions to improve the clarity and conciseness of the new content, aligning with the style guide's principle of avoiding unnecessary words.

@hfxsd
Copy link
Collaborator

hfxsd commented Sep 24, 2025

/approve

Copy link

ti-chi-bot bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit 5fd80a9 into pingcap:release-8.5 Sep 24, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-21819-to-release-8.5 branch September 24, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants