tidb: add skip-init-stats config #21766
Conversation
ti-chi-bot
bot
added
the
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @0xPoe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces documentation for a newly added configuration parameter, skip-init-stats, within the TiDB configuration file. The purpose is to inform users about this option, which allows for bypassing statistics initialization during TiDB startup, offering a way to accelerate startup times in specific, advanced scenarios, while also highlighting potential performance implications if used improperly.
Highlights
- Documentation for skip-init-stats: Added a new section to tidb-configuration-file.md detailing the skip-init-stats configuration option. This includes its purpose (skipping statistics initialization during TiDB startup), default value (false), and important considerations regarding its use, particularly for performance and optimizer behavior.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
the
size/XS
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the new skip-init-stats configuration option. The added content is clear and well-placed. I have one minor suggestion to improve the wording and tone of the description to better align with the documentation style guide.
ti-chi-bot
bot
added
size/S
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for the skip-init-stats configuration option in TiDB, which allows skipping statistics initialization during startup. The configuration is intended for special scenarios where quick startup is prioritized over having accurate statistics available.
- Adds documentation for the new
skip-init-statsconfig parameter introduced in TiDB v9.0.0 - Includes appropriate warning about production usage and potential impact on query optimization
- Provides clear explanation of the tradeoffs between startup speed and optimizer performance
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
qiancai
added
v9.0-beta.3
ti-chi-bot
bot
removed
the
missing-translation-status
Co-authored-by: Roger Song <[email protected]>
Co-authored-by: Roger Song <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
qiancai
added
translation/done
First-time contributors' checklist
What is changed, added or deleted? (Required)
close pingcap/tidb#63103
In this PR, I added the doc for the
skip-init-statsconfig, which has been added recently. pingcap/tidb#63104Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?