Skip to content

fix: handle primitive return types in response info attachment #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxwellCalkin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle primitive return types in response info attachment #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pinecone/openapi_support/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,11 @@ def __call_api(
response_info = extract_response_info(headers)
if isinstance(return_data, dict):
return_data["_response_info"] = response_info
else:
elif hasattr(return_data, "__dict__"):
# Dynamic attribute assignment on OpenAPI models
setattr(return_data, "_response_info", response_info)
# Primitive types (str, int, float, bool) do not support
# attribute assignment, so response_info is silently skipped.

if _return_http_data_only:
return return_data
Expand Down
4 changes: 3 additions & 1 deletion pinecone/openapi_support/asyncio_api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,11 @@ async def __call_api(
response_info = extract_response_info(headers)
if isinstance(return_data, dict):
return_data["_response_info"] = response_info
else:
elif hasattr(return_data, "__dict__"):
# Dynamic attribute assignment on OpenAPI models
setattr(return_data, "_response_info", response_info)
# Primitive types (str, int, float, bool) do not support
# attribute assignment, so response_info is silently skipped.

if _return_http_data_only:
return return_data
Expand Down