Add support for list, describe, and delete namespaces in grpc#517
Merged
rohanshah18 merged 4 commits intomainfrom Jun 27, 2025
Merged
Add support for list, describe, and delete namespaces in grpc#517rohanshah18 merged 4 commits intomainfrom
rohanshah18 merged 4 commits intomainfrom
Conversation
austin-denoble
approved these changes
Jun 27, 2025
Contributor
austin-denoble
left a comment
There was a problem hiding this comment.
LGTM, the one thing I noticed is we should probably delete the old 2025-01 grpc files since they're no longer being used, and I think we used to do this in the past:
db_data_2025_01_pb2_grpc.pydb_data_2025_01_pb2.pydb_data_2025_01_pb2.pyi
| # -*- coding: utf-8 -*- | ||
| # Generated by the protocol buffer compiler. DO NOT EDIT! | ||
| # NO CHECKED-IN PROTOBUF GENCODE | ||
| # source: db_data_2025-04.proto |
Contributor
Contributor
Author
There was a problem hiding this comment.
Yeah, I don't have much context here on whether we delete the older versions or not, but it definitely feels weird not deleting 2025_01. In the future, I'd like to add the following steps to build-grpc.sh:
- Before code generation: Delete old proto files.
- After code generation: Either
- Update all
yyyy-mmreferences in the codebase so we don’t have to manually edit the imports, or - Rename the proto files to remove
yyyy-mm, so no edits are required in the codebase.
- Update all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Support for REST sync and async namespaces was added in a previous PR, so this PR adds support for gRPC only.
Solution
Add support for list, describe, and delete namespaces in grpc.
Type of Change
Test Plan
Added integration and unit tests