Update EmbedResponse and DescribeIndexStatsResponse
#134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerated types: include VectorType in EmbedResponse; include Metric, VectorType, MemoryFullness, and StorageFullness in DescribeIndexStatsResponse, add unit test coverage for converters
…t the timeout for integration runs in CI to 20m. this will need to be addressed later to bring the overall time down significantly
austin-denoble
deleted the
adenoble/resolve-type-conversion-discrepancies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After resolving type conversion issues (missing fields) on
NamespaceDescription, I did a pass looking for other areas where we may have missed fields.There were two other areas that need updating:
EmbedResponse- missingVectorTypeDescribeIndexStatsResponse- missingMetric,VectorType,MemoryFullness, andStorageFullnessSolution
Resolve missing fields between types the SDK exposes and internally generated types: include VectorType in EmbedResponse; include Metric, VectorType, MemoryFullness, and StorageFullness in DescribeIndexStatsResponse, add unit test coverage for converters.
Also pulled in a dependabot update that was raised in this PR: #134
Bumped the
js-yamltransitive dependency in.github/actions/bump-version.Type of Change
Test Plan
CI - Unit and Integration Tests