Fix ListNamespaces responses, centralize NamespaceDescription conversion
#133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Found another problem with
NamespaceDescriptionresponses.IndexConnection.ListNamespaceswas not properly attachingSchemaorIndexedFieldstoNamespaceDescription. This was the same issue seen in theCreateNamespacemethod fixed in a previous PR: #132Solution
Centralize logic for conversion between
db_data_grpc.NamespaceDescription->NamespaceDescriptionintoNamespaceDescription.Fix
ListNamespacesconversion ofNamespaceDescriptionresponse objects viatoNamespaceDescription. Reuse for create, list, and describe namespace operations.Type of Change
Test Plan
CI - unit & integration tests