Skip to content

Conversation

@austin-denoble
Copy link
Contributor

Problem

Found another problem with NamespaceDescription responses. IndexConnection.ListNamespaces was not properly attaching Schema or IndexedFields to NamespaceDescription. This was the same issue seen in the CreateNamespace method fixed in a previous PR: #132

Solution

Centralize logic for conversion between db_data_grpc.NamespaceDescription->NamespaceDescription in toNamespaceDescription.
Fix ListNamespaces conversion of NamespaceDescription response objects via toNamespaceDescription. Reuse for create, list, and describe namespace operations.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

CI - unit & integration tests

…entralize logic for conversion in toNamespaceDescription, reuse for create, list, and describe namespace operations
@austin-denoble austin-denoble merged commit 3c4f1a3 into main Dec 15, 2025
5 checks passed
@austin-denoble austin-denoble deleted the adenoble/fix-list-namespaces-response branch December 15, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants