Fix ] in the if statement on line 64 #37
Conversation
damacus
commented
Nov 27, 2023
damacus
commented
- Also fixes a number of shellcheck errors which prevents future errors
- Also fixes a number of shellcheck errors which prevents future errors Signed-off-by: Dan Webb <[email protected]>
|
I'm guessing this should probably get fixed in the wrapper/template script repo. @Gadgetoid want me to try and fix it over there? |
Yes please, the boilerplate has a work-in-progress branch with all the latest changes here - pimoroni/boilerplate-python#13 I'm in the process of migrating dozens of libraries, see: pimoroni/boilerplate-python#16 - so it would be really helpful to get this stuff right! |
|
Ace. I'll try and lend a hand over there. I actually can't see why that particular error crept on! Keep up the awesome work 😎 |
I can 😭 I'm not quite cut out to coordinate this massive upheaval of so many projects, so my brain tends to wander and miss things. |
|
Right, looking back at this I think it would be prudent to add shellcheck to our linting/spelling CI! |
This was inspired by and built upon Dan's PR here: pimoroni/grow-python#37 Co-authored-by: Dan Webb <[email protected]>
|
👍🏼 I've found a decent action I'll make a Pr later today |
|
Ooh, interesting! I smashed something together based on our exiting Make-based workflow (and fixed all the warnings and style suggestions), but the Action might be preferable just for better error reporting - pimoroni/boilerplate-python@5e294af |
