Add strictValidation option for Kernel accounts#471
Add strictValidation option for Kernel accounts#471dimitricole wants to merge 1 commit intopimlicolabs:mainfrom
Conversation
This change adds support for validators that require real signatures during gas estimation, such as Kernel v3 custom validators. Changes: - Add strictValidation parameter to ToKernelSmartAccountParameters - Update sendTransaction to sign UserOperations before gas estimation when strictValidation is enabled - Add tests verifying strictValidation behavior The feature is backward compatible, defaulting to false to maintain existing behavior.
|
|
Can you share the specific use case where the estimations were wrong and you had to resolve to a strict use case of using the actual signature? If someone does want to estimate with real signature they should themselves use the low level functions as this is not the expected behaviour. The expected behaviour for calls is:
Also signing a user operation which is not fully prepared can also lead to security issues. |
This change adds support for validators that require real signatures during gas estimation, such as Kernel v3 custom validators.
Changes:
The feature is backward compatible, defaulting to false to maintain existing behavior.