Skip to content

Notificaion polishing #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
May 28, 2025
Merged

Notificaion polishing #1538

merged 28 commits into from
May 28, 2025

Conversation

xIrusux
Copy link
Contributor

@xIrusux xIrusux commented May 27, 2025

Changes in this pull request

Resolves #

Additional info

Polished Send Notification Modal:

  • add loading state to send button (ie. custom modal footer)
  • allow text search in select for notification recipient
  • adjusted shared components to optionally allow the above
  • show success snack bar message on successful sending of notification
  • add icon on send modal
  • show loading buffer when switching sides / on fetching not just loading

Adjust for backend updates:

2 Questions / Thoughts:

  • it feels a bit odd to me that one can only add one attachment
  • ui of "attachment select" could be more intuitive.
    As in below shot user hovers and sees the tooltip "Open" but icon is greyed out. Cause it is the first Icon it draws the users attention anyway. I think the other icons should be invisible
    Screenshot from 2025-05-28 11-02-23

@xIrusux xIrusux marked this pull request as ready for review May 28, 2025 10:28
@xIrusux xIrusux requested a review from markus-moser May 28, 2025 10:40
@xIrusux
Copy link
Contributor Author

xIrusux commented May 28, 2025

Screencast.from.2025-05-28.12-43-29.webm

Copy link
Contributor

@markus-moser markus-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM - I just added 2 comments, please check them before merging it 👍

@markus-moser
Copy link
Contributor

it feels a bit odd to me that one can only add one attachment

We cannot change this as we would need to also adjust it in the classic bundle. One attachment is fine for this use case.

ui of "attachment select" could be more intuitive.
As in below shot user hovers and sees the tooltip "Open" but icon is greyed out. Cause it is the first Icon it draws the users > attention anyway. I think the other icons should be invisible

I tend to agree but let's keep it like it is. At the moment in a lot of situations we do this and it's also done like this in the classic bundle. We would need to think about it in a holistic way - not that important for now...

Copy link

@xIrusux xIrusux merged commit 5e41974 into 1.x May 28, 2025
@xIrusux xIrusux deleted the notificaion-polishing branch May 28, 2025 13:58
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
@markus-moser markus-moser added this to the next milestone May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants