1042 relation data path formatter #1447
Conversation
| return acc | ||
| }, {}) | ||
|
|
||
| const { data } = await store.dispatch(api.endpoints.dataObjectFormatPath.initiate({ |
There was a problem hiding this comment.
Can we add some kind of caching here so that we don't request items with the same context information again after we already requested it? (so just remember the result in a local ref or so)
assets/js/src/core/modules/data-object/hooks/use-data-object-helper.ts
Outdated
Show resolved
Hide resolved
...c-types/definitions/objects/data-related/components/many-to-many-relation/hooks/use-value.ts
Outdated
Show resolved
Hide resolved
| <Tag | ||
| bordered={ false } | ||
| color="geekblue" | ||
| ><SanitizeHtml html={ info.getValue() ?? '' } /></Tag> |
There was a problem hiding this comment.
This works for many-to-many-relations but unfortunately it seems that we need to find other locations where we need to apply this for the other multi-relation data types:
...ent/dynamic-types/definitions/objects/data-related/components/many-to-many-relation/grid.tsx
Outdated
Show resolved
Hide resolved
| @@ -79,7 +81,7 @@ export const ManyToManyRelation = (props: ManyToManyRelationProps): React.JSX.El | |||
| } | |||
| }, [JSON.stringify(props.value)]) | |||
|
|
|||
| if (props.isLoading === true) { | |||
| if (isLoading || props.isLoading === true) { | |||
There was a problem hiding this comment.
The loading state here seemed to be a good idea, but it's a bit annoying that the full data type has a loading state - especially when a new item is added via the tree. The grid data type itself also provides a loading prop. Maybe it's better to just set the grid itself to loading instead of everything? Not sure how easy it's possible but in a perfect world we would see the loading spinner directly on row level for newly added items (and only for the initial load we use the global one).
| @@ -33,22 +38,47 @@ interface UseValueReturn { | |||
| addItems: (items: ManyToManyRelationValueItem[]) => void | |||
| addAssets: (assets: Asset[]) => Promise<void> | |||
| maxRemainingItems?: number | |||
| pathFormatterClass?: string | null | |||
There was a problem hiding this comment.
Currently we have the loading spinner + the triggered format-path request also when no path formatter is configured. We need to find a way to skip the path formatter logic when no pathFormatterClass is defined.
| body: { | ||
| objectId: dataObjectId, | ||
| targets, | ||
| context: { |
There was a problem hiding this comment.
It will be a bit tricky but we need to somehow find a way to respect the different possible context cases:
|
Changes in this pull request
Resolves #1042
Additional info