Skip to content

[Bug] Base permissions should be false by default #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024
Merged

[Bug] Base permissions should be false by default #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15db02c
fix: base permissions should be false by default
lukmzig Nov 5, 2024
73e16bf
fix: codeception unit tests
lukmzig Nov 5, 2024
3aafd70
fix: codeception unit tests
lukmzig Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Permission/BasePermissions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
*/
abstract class BasePermissions
{
// TODO: Change default value once development of API is finished
protected const DEFAULT_VALUE = true;
protected const DEFAULT_VALUE = false;

private bool $list = self::DEFAULT_VALUE;

Expand Down
30 changes: 15 additions & 15 deletions tests/Unit/Service/EventServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ final class EventServiceTest extends Unit
public function testDispatchAssetSearchEvent(): void
{
$permissions = new AssetPermissions();
$permissions->setView(false);
$permissions->setRename(false);
$permissions->setView(true);
$permissions->setRename(true);

$event = new Event\Asset\PermissionEvent(
new AssetSearchResultItem(),
Expand All @@ -51,16 +51,16 @@ public function testDispatchAssetSearchEvent(): void
);

$this->assertSame($event->getPermissions(), $returnedEvent->getPermissions());
$this->assertFalse($returnedEvent->getPermissions()->isView());
$this->assertFalse($returnedEvent->getPermissions()->isRename());
$this->assertTrue($returnedEvent->getPermissions()->isList());
$this->assertTrue($returnedEvent->getPermissions()->isView());
$this->assertTrue($returnedEvent->getPermissions()->isRename());
$this->assertFalse($returnedEvent->getPermissions()->isList());
}

public function testDispatchDataObjectSearchEvent(): void
{
$permissions = new DataObjectPermissions();
$permissions->setView(false);
$permissions->setRename(false);
$permissions->setView(true);
$permissions->setRename(true);

$event = new Event\DataObject\PermissionEvent(
new DataObjectSearchResultItem(),
Expand All @@ -74,16 +74,16 @@ public function testDispatchDataObjectSearchEvent(): void
);

$this->assertSame($event->getPermissions(), $returnedEvent->getPermissions());
$this->assertFalse($returnedEvent->getPermissions()->isView());
$this->assertFalse($returnedEvent->getPermissions()->isRename());
$this->assertTrue($returnedEvent->getPermissions()->isList());
$this->assertTrue($returnedEvent->getPermissions()->isView());
$this->assertTrue($returnedEvent->getPermissions()->isRename());
$this->assertFalse($returnedEvent->getPermissions()->isList());
}

public function testDispatchDocumentSearchEvent(): void
{
$permissions = new DocumentPermissions();
$permissions->setView(false);
$permissions->setList(false);
$permissions->setView(true);
$permissions->setList(true);

$event = new Event\Document\PermissionEvent(
new DocumentSearchResultItem(),
Expand All @@ -97,9 +97,9 @@ public function testDispatchDocumentSearchEvent(): void
);

$this->assertSame($event->getPermissions(), $returnedEvent->getPermissions());
$this->assertFalse($returnedEvent->getPermissions()->isView());
$this->assertFalse($returnedEvent->getPermissions()->isList());
$this->assertTrue($returnedEvent->getPermissions()->isPublish());
$this->assertTrue($returnedEvent->getPermissions()->isView());
$this->asserttrue($returnedEvent->getPermissions()->isList());
$this->assertFalse($returnedEvent->getPermissions()->isPublish());
}

public function testEventDispatcherCall(): void
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Service/Permission/PermissionServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
*/
final class PermissionServiceTest extends Unit
{
private const DEFAULT_VALUE = true;
private const DEFAULT_VALUE = false;

private User $user;

Expand Down
Loading