Skip to content

Add and improve sort order modifiers #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 30, 2024
Merged

Add and improve sort order modifiers #183

merged 16 commits into from
Jul 30, 2024

Conversation

@markus-moser
Copy link
Contributor

@markus-moser markus-moser commented Jul 22, 2024

  • Add OrderByField modifier
  • Implement mapping/logic for case insensitive sorting
  • Change OrderByFullPath modifier to respect case insensitive sorting

@markus-moser markus-moser added this to the 1.2.0 milestone Jul 22, 2024
@markus-moser markus-moser marked this pull request as ready for review July 22, 2024 11:56
martineiber
martineiber approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@martineiber martineiber mentioned this pull request Jul 29, 2024
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@markus-moser markus-moser merged commit d277e9e into 1.x Jul 30, 2024
@markus-moser markus-moser deleted the sort-modifier branch July 30, 2024 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@martineiber martineiber martineiber approved these changes

Assignees

No one assigned

Labels

Improvement

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@markus-moser @martineiber