Skip to content

[Improvement]: Distinguish relation conditions applied as preconditions #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

[Improvement]: Distinguish relation conditions applied as preconditions #249

wants to merge 3 commits into from
+119 −92

Conversation

dolmit-tanel-paaro
Copy link
Contributor

Resolves #248

@dolmit-tanel-paaro dolmit-tanel-paaro force-pushed the distinguish-relation-conditions-applied-as-preconditions branch 3 times, most recently from fafe916 to 9b70410 Compare April 11, 2025 12:05
@dolmit-tanel-paaro
Copy link
Contributor Author

dolmit-tanel-paaro commented Apr 11, 2025 •
edited
Loading

I'm not sure if we also should update filters in Findologic and SearchIndex namespaces.

@dolmit-tanel-paaro
Copy link
Contributor Author

I'm not sure if we also should update filters in Findologic and SearchIndex namespaces.

Updated those classes too.

@dolmit-tanel-paaro dolmit-tanel-paaro force-pushed the distinguish-relation-conditions-applied-as-preconditions branch from 92e3083 to 84fb3a3 Compare April 11, 2025 12:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.4% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 self-assigned this May 27, 2025
kingjia90
kingjia90 requested changes May 27, 2025
View reviewed changes
Copy link
Contributor

@kingjia90 kingjia90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

I have Just found this inconsistency after a quick scan, haven't tested it yet all, not very familiar with this topic yet

@dolmit-tanel-paaro dolmit-tanel-paaro force-pushed the distinguish-relation-conditions-applied-as-preconditions branch from 63ac52a to da0d776 Compare May 28, 2025 06:07
@dolmit-tanel-paaro dolmit-tanel-paaro force-pushed the distinguish-relation-conditions-applied-as-preconditions branch from da0d776 to 666bfe6 Compare May 28, 2025 10:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.4% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingjia90 kingjia90 kingjia90 requested changes

Assignees

@kingjia90 kingjia90

Labels
Pimcore:Priority Pimcore:ToDo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Distinguish relation conditions applied as preconditions
4 participants
@dolmit-tanel-paaro @kingjia90 @heigpa @wisconaut