Skip to content

Support for adjusting batch-size in ProcessUpdateIndexQueueCommand #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2025

Conversation

jremmurd
Copy link
Contributor

@jremmurd jremmurd commented Feb 19, 2025

With this PR it gets possible to adjust the batch size using the existing command option.

Example: bin/console ecommerce:indexservice:process-update-queue --timeout=5 --processes=3 --batch-size=50

From the docs:

The batch size is determined by getBatchSize() and defaults to the segment
size. The segment size is the number of items a worker (child) process
consumes before it dies. This means that, by default, a child process will
process all its items, persist them in a batch and then die. If you want
to improve the performance of your command, try to tweak getSegmentSize()
first. Optionally, you can tweak getBatchSize() to process multiple batches
in each child process.

Copy link

github-actions bot commented Feb 19, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jremmurd
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jremmurd jremmurd marked this pull request as ready for review February 19, 2025 09:38
Copy link

@herbertroth
Copy link
Member

@jremmurd Could you please rebase this PR to the 2.x branch? There won’t be a 1.4 release. Thanks!

@fashxp fashxp changed the base branch from 1.x to 2.x April 7, 2025 12:59
@fashxp
Copy link
Member

fashxp commented Apr 7, 2025

no need for rebase when chaging base-branch to upstream :-)

@mcop1 mcop1 self-assigned this May 23, 2025
@mcop1 mcop1 modified the milestones: 1.3.2, 3.0.0 May 23, 2025
@mcop1 mcop1 merged commit 93cea83 into pimcore:2.x May 26, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2025
@mcop1
Copy link
Contributor

mcop1 commented May 26, 2025

Thanks of the pr!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants