Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to prevent wrong devices in discovery #88

Closed
wants to merge 3 commits into from
+18 −8
Closed

try to prevent wrong devices in discovery #88

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9dbccb0
Merge pull request #1 from pimatic/master
sweebee Mar 17, 2018
9bf68de
do a quick check on temperature and/or humidity to try to prevent inv…
Mar 17, 2018
a4f6f1e
only listen to "on" event on switch discovery to prevent wrong device…
Mar 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions homeduino.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,20 +78,30 @@ module.exports = (env) ->

switch protocol.type
when 'switch'
config = {
class: 'HomeduinoRFSwitch'
protocols: protocolConfig
}
if event.values.state is true
config = {
class: 'HomeduinoRFSwitch'
protocols: protocolConfig
}
when 'dimmer'
config = {
class: 'HomeduinoRFDimmer'
protocols: protocolConfig
}
when 'weather'
config = {
class: 'HomeduinoRFWeatherStation'
protocols: protocolConfig
}
valid = true
if typeof event.values.temperature != 'undefined'
if event.values.temperature > 100 or event.values.temperature < -30
valid = false
if typeof event.values.humidity != 'undefined'
if event.values.humidity < 0 or event.values.humidity > 100
valid = false
if valid
console.log(event)
config = {
class: 'HomeduinoRFWeatherStation'
protocols: protocolConfig
}
when 'contact'
config = {
class: 'HomeduinoRFContactSensor'
Expand Down