bugfix: move cement losses behind cement market - #164
Merged
bennet21 merged 4 commits intoJul 29, 2026
Conversation
for more information, see https://pre-commit.ci
bennet21
requested review from
leonieschweiger and
tobiasdiez
and removed request for
leonieschweiger and
tobiasdiez
July 28, 2026 08:57
JakobBD
approved these changes
Jul 29, 2026
JakobBD
left a comment
JakobBD
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, as the pros seem to say 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cement losses refer to share of cement lost during the construction phase. This means the loss must not be applied after production, but rather after the cement market. This PR fixes that.