Fix capitalization of 'BOF' in parameters - #151
Closed
tobiasdiez wants to merge 2 commits into
Closed
Conversation
JakobBD
approved these changes
Jul 7, 2026
JakobBD
left a comment
Collaborator
There was a problem hiding this comment.
Interesting that Windows seems to be case insensitive when looking for files?
I'd prefer to change the file name (no good reason for capitalization here). But it requires to have the R packages set up.
If you want to merge it now to have a working version, I'm fine with it!
We can revert the commits once we changed mrmrfa (probably never :-D )
Contributor
Author
|
Proper fix is at pik-piam/mrmfa#64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file is called
st_scrap_in_BOF_rate.cs4rwith a capitalBOF, which lead to errors as it couldn't be found (perhaps a linux/windows issue).Thus used the capitalized version everywhere (where I could find
scrap_in_bof_rate). The alternative would be renaming the file to lower case.