Skip to content

Fix capitalization of 'BOF' in parameters - #151

Closed
tobiasdiez wants to merge 2 commits into
mainfrom
steel-bof
Closed

Fix capitalization of 'BOF' in parameters#151
tobiasdiez wants to merge 2 commits into
mainfrom
steel-bof

Conversation

@tobiasdiez

Copy link
Copy Markdown
Contributor

The file is called st_scrap_in_BOF_rate.cs4r with a capital BOF, which lead to errors as it couldn't be found (perhaps a linux/windows issue).

Thus used the capitalized version everywhere (where I could find scrap_in_bof_rate). The alternative would be renaming the file to lower case.

@JakobBD JakobBD left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that Windows seems to be case insensitive when looking for files?

I'd prefer to change the file name (no good reason for capitalization here). But it requires to have the R packages set up.

If you want to merge it now to have a working version, I'm fine with it!
We can revert the commits once we changed mrmrfa (probably never :-D )

@tobiasdiez

Copy link
Copy Markdown
Contributor Author

Proper fix is at pik-piam/mrmfa#64

@tobiasdiez tobiasdiez closed this Jul 13, 2026
@tobiasdiez
tobiasdiez deleted the steel-bof branch July 13, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants