feat: plot parameters - #146
Open
bennet21 wants to merge 4 commits into
Open
Conversation
for more information, see https://pre-commit.ci
…/remind-mfa into develop/parameter-visualization
JakobBD
reviewed
Jul 7, 2026
JakobBD
left a comment
JakobBD
left a comment
Collaborator
There was a problem hiding this comment.
Not sure what to do with this.
It's nice added functionality, and the vibe coded bit are mostly confined to one file, but still I think it would be nice to refactor this before merging:
- split up the main function a bit
- comment your code
- It seems like a lot of duplicated functionality with the ArrayPlotter. Maybe use that instead to shorten the code?
|
|
||
|
|
||
| class ParameterPlotsExportCfg(BaseExportCfg): | ||
| do_export: bool = False |
Collaborator
There was a problem hiding this comment.
I think I'd rather have it added to the config files with False instead of making a new subclass here.
Alternatively, you could rename the subclass to OptionalExportCfg to make it more general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Vibe-coded]
Creates a PDF with plots of all parameters across all of their dimensions. Historical and Future parameters are plotted separately as sanity check (they should ofc overlap).