Added SusMIP mapping file - #553
Conversation
|
@fbenke-pik could you please help with teh checking |
|
Thank you, @trakshayaofficial, for setting up the mapping file! I would suggest that we split the review in two parts: (1) content, (2) technical
|
|
I am in touch with Akshaya regarding 2) |
weindl
left a comment
There was a problem hiding this comment.
Thank you for the new SusMIP mapping file.
I checked exemplary mappings for the land and agricultural sector.
I noticed inconsistencies with existing mappings (e.g. ScenarioMIP or EC). These inconsistencies seem to have a common root problem: in case that a project variable has to be mapped to the sum of several model variables, we need in the mapping file several rows where on the left we have several instances of the project variable to represent the sum over the model variables represented by the individual rows.
Very likely the current version of the SusMIP mapping file has more instances where the sum that was present in existing mappings was not correctly transferred to this mapping.
Therefore I propose to check the entire file regarding those cases and revise the inconsistencies.
| @@ -0,0 +1,337 @@ | |||
| variable;unit;piam_variable;piam_unit;piam_factor;description;source | |||
| Fertilizer Use|Phosphorus;Tg P/yr;;;;total phosphorus fertilizer use (organic + inorganic); | |||
| Fertilizer Use|Nitrogen|Organic;Tg N/yr;Resources|Nitrogen|Cropland Budget|Inputs|+|Manure Recycled from Confinements;Mt Nr/yr;;Total nitrogen inputs in organic fertilizer use;M | |||
There was a problem hiding this comment.
I compared the mapping for 'Fertilizer Use|Nitrogen|Organic' with the one in the 'ScenarioMIP template' (mapping_ScenarioMIP.csv), where it is:
Fertilizer Use|Nitrogen|Organic;Tg N/yr;2;Organic nitrogen fertilizer use on cropland (e.g. manure);;Resources|Nitrogen|Cropland Budget|Inputs|+|Manure Recycled from Confinements;Mt Nr/yr;;;M;
Fertilizer Use|Nitrogen|Organic;Tg N/yr;2;Organic nitrogen fertilizer use on cropland (e.g. manure);;Resources|Nitrogen|Cropland Budget|Inputs|+|Manure From Stubble Grazing;Mt Nr/yr;;;M;
Please also add the second column such that 'Fertilizer Use|Nitrogen|Organic' is the sum of the 2 MAgPIE variables.
| Material recycling|Chemicals;Mt/year;;;;Mass of Chemicals recycled per year; | ||
| Material recycling|Plastics;Mt/year;;;;Mass of Plastics recycled per year; | ||
| Material recycling|Steel;Mt/year;;;;Mass of Steel recycled per year; | ||
| Agricultural Production;million t DM/yr;Production|+|Crops;Mt DM/yr;;total production of food,non-food and feed products (crops and livestock) and bioenergy crops (1st & 2nd generation);M |
There was a problem hiding this comment.
Filling of Agricultural Production with only Production|+|Crops covers only a subset of all production from the agricultural sector. Compare the ScenarioMIP template (mapping_ScenarioMIP.csv) for the complete mapping:
Agricultural Production;million t DM/yr;1;Total production of food, non-food and feed products (crops and livestock) and bioenergy crops (1st & 2nd generation);;Production|+|Crops;Mt DM/yr;;mapping taken from NAVIGATE, NAVIGATE category: agriculture;M;
Agricultural Production;million t DM/yr;1;Total production of food, non-food and feed products (crops and livestock) and bioenergy crops (1st & 2nd generation);;Production|+|Livestock products;Mt DM/yr;;mapping taken from NAVIGATE, NAVIGATE category: agriculture;M;
Agricultural Production;million t DM/yr;1;Total production of food, non-food and feed products (crops and livestock) and bioenergy crops (1st & 2nd generation);;Production|+|Bioenergy crops;Mt DM/yr;;mapping taken from NAVIGATE, NAVIGATE category: agriculture;M;
Agricultural Production;million t DM/yr;1;Total production of food, non-food and feed products (crops and livestock) and bioenergy crops (1st & 2nd generation);;Demand|Bioenergy|+|Crop residues;Mt DM/yr;;mapping taken from NAVIGATE, NAVIGATE category: agriculture;M;
Agricultural Production;million t DM/yr;1;Total production of food, non-food and feed products (crops and livestock) and bioenergy crops (1st & 2nd generation);;Demand|Feed|+|Crop residues;Mt DM/yr;;mapping taken from NAVIGATE, NAVIGATE category: agriculture;M;
Agricultural Production;million t DM/yr;1;Total production of food, non-food and feed products (crops and livestock) and bioenergy crops (1st & 2nd generation);;Demand|Material|+|Crop residues;Mt DM/yr;;mapping taken from NAVIGATE, NAVIGATE category: agriculture;M;
| Freshwater|Environmental Flow;km3/yr;;;;water allocated to environmental flow in rivers and groundwater systems; | ||
| Population|Drinking Water Access;million;;;;population with access to improved drinking water sources (by income level); | ||
| Population|Sanitation Access;million;;;;population with access to improved sanitation (by income level); | ||
| Water Consumption;km3/yr;;;;total water consumption; |
There was a problem hiding this comment.
Water Consumption can also be mapped (see ScenarioMIP template (mapping_ScenarioMIP.csv)):
Water Consumption;km3/yr;;Total water consumption;;Water Consumption|Electricity;km3/yr;;;Rx;
Water Consumption;km3/yr;;Total water consumption;;Resources|Water|Consumption|Agriculture;km3/yr;;;M;
Water Consumption;km3/yr;;Total water consumption;;Resources|Water|Consumption|Non-agriculture|+|manufacturing;km3/yr;;;M;
Water Consumption;km3/yr;;Total water consumption;;Resources|Water|Consumption|Non-agriculture|+|domestic;km3/yr;;;M;
| Water Consumption|Irrigation;km3/yr;;;;water consumption for the irrigation; | ||
| Water Consumption|Livestock;km3/yr;;;;water consumption for livestock; | ||
| Water Consumption|Municipal Water;km3/yr;;;;water consumption for the municipal sector (e.g.,houses,offices,municipal irrigation); | ||
| Water Withdrawal;km3/yr;;;;total water withdrawal; |
There was a problem hiding this comment.
Water Withdrawal can also be mapped (see ScenarioMIP template (mapping_ScenarioMIP.csv)):
Water Withdrawal;km3/yr;;Total water withdrawals;;Water Withdrawal|Electricity;km3/yr;;;Rx;
Water Withdrawal;km3/yr;;Total water withdrawals;;Resources|Water|Withdrawal|Agriculture;km3/yr;;;M;
Water Withdrawal;km3/yr;;Total water withdrawals;;Resources|Water|Withdrawal|Non-agriculture|+|manufacturing;km3/yr;;;M;
Water Withdrawal;km3/yr;;Total water withdrawals;;Resources|Water|Withdrawal|Non-agriculture|+|domestic;km3/yr;;;M;
| Inequality Index|Gini;unitless;;;;; | ||
| Nutrients|Nitrogen|Cropland Budget|Inputs;Tg N/yr;Resources|Nitrogen|Cropland Budget|Inputs;Mt Nr/yr;;;M | ||
| Nutrients|Nitrogen|Cropland Budget|Inputs|Atmospheric Deposition;Tg N/yr;Resources|Nitrogen|Cropland Budget|Inputs|+|Atmospheric Deposition;Mt Nr/yr;;;M | ||
| Nutrients|Nitrogen|Cropland Budget|Inputs|Biological Fixation;Tg N/yr;Resources|Nitrogen|Cropland Budget|Inputs|+|Biological Fixation Freeliving Microorganisms;Mt Nr/yr;;;M |
There was a problem hiding this comment.
Instead of Nutrients|Nitrogen|Cropland Budget|Inputs|Biological Fixation;Tg N/yr;Resources|Nitrogen|Cropland Budget|Inputs|+|Biological Fixation Freeliving Microorganisms;Mt Nr/yr;;;M (see https://github.com/pik-piam/piamInterfaces/blob/master/inst/mappings/mapping_EC.csv):
Nutrients|Nitrogen|Cropland Budget|Inputs|Biological Fixation;Tg N/yr;;;;Resources|Nitrogen|Cropland Budget|Inputs|+|Biological Fixation Freeliving Microorganisms;Mt Nr/yr;;;M;
Nutrients|Nitrogen|Cropland Budget|Inputs|Biological Fixation;Tg N/yr;;;;Resources|Nitrogen|Cropland Budget|Inputs|+|Biological Fixation Symbiotic Crops;Mt Nr/yr;;;M;
| Carbon Removal|Geological Storage|Direct Air Capture;Mt CO2/yr;Emi|CO2|CDR|+|DACCS;Mt CO2/yr;-1;Gross removals of carbon dioxide (CO2) through direct air capture in combination with carbon-capture and sequestration (CCS);R | ||
| Carbon Removal|Geological Storage|Other Sources;Mt CO2/yr;;;;Gross removals of carbon dioxide (CO2) through geological storage of CO2 from other sources, not including carbon from fossil fuels; | ||
| Carbon Removal|Geological Storage|Synthetic Fuels;Mt CO2/yr;Emi|CO2|CDR|+|Synthetic Fuels CCS;Mt CO2/yr;-1;Gross removals of carbon dioxide (CO2) through geological storage of CO2 captured from burning synthetic fuels produced from carbon-capture-and-utilization (CCU), not derived from fossil fuels;R | ||
| Carbon Removal|Land Use;Mt CO2/yr;Emissions|CO2|Land|Land-use Change|Regrowth|+|CO2-price AR;Mt CO2/yr;-1;Gross removals of carbon dioxide (CO2) through land-based sinks (e.g., afforestation, soil carbon enhancement, biochar);M |
There was a problem hiding this comment.
Again, also here Carbon Removal|Land Use is mapped to a sum of model variables:
Carbon Removal|Land Use;Mt CO2/yr;1;Gross removals of carbon dioxide (CO2) through land-based sinks (e.g., afforestation, soil carbon enhancement, biochar);Values should be reported as positive numbers.;Emissions|CO2|Land|Land-use Change|Regrowth|+|CO2-price AR;Mt CO2/yr;-1;;M;
Carbon Removal|Land Use;Mt CO2/yr;1;Gross removals of carbon dioxide (CO2) through land-based sinks (e.g., afforestation, soil carbon enhancement, biochar);Values should be reported as positive numbers.;Emissions|CO2|Land|Land-use Change|Regrowth|+|NPI_NDC AR;Mt CO2/yr;-1;;M;
Carbon Removal|Land Use;Mt CO2/yr;1;Gross removals of carbon dioxide (CO2) through land-based sinks (e.g., afforestation, soil carbon enhancement, biochar);Values should be reported as positive numbers.;Emissions|CO2|Land|Land-use Change|Regrowth|+|Cropland Tree Cover;Mt CO2/yr;-1;;M;
Carbon Removal|Land Use;Mt CO2/yr;1;Gross removals of carbon dioxide (CO2) through land-based sinks (e.g., afforestation, soil carbon enhancement, biochar);Values should be reported as positive numbers.;Emissions|CO2|Land|Land-use Change|Soil|Soil Carbon Management|+|Withdrawals;Mt CO2/yr;-1;;M;
Carbon Removal|Land Use;Mt CO2/yr;1;Gross removals of carbon dioxide (CO2) through land-based sinks (e.g., afforestation, soil carbon enhancement, biochar);Values should be reported as positive numbers.;Emissions|CO2|Land|Land-use Change|Peatland|+|Negative;Mt CO2/yr;-1;Peatland negative CO2 emissions - very small;M;
bugfix Population|Prevalence of Normal Weight
weindl
left a comment
There was a problem hiding this comment.
All comments have been adressed.
| Final Energy|Transportation|Light-Duty Vehicle;EJ/yr;FE|Transport|Pass|Road|LDV;EJ/yr;;Final energy consumption by the transportation sector with light-duty vehicles;T | ||
| Final Energy|Transportation|Truck;EJ/yr;FE|Transport|Freight|Road;EJ/yr;;Final energy consumption by the trucking sector;T | ||
| Food Availability [per capita];kcal/cap/day;Nutrition|Calorie Supply;kcal/capita/day;;Amount of food available from crops, secondary products and livestock products;M | ||
| Food Availability|Crops [per capita];kcal/cap/day;Nutrition|Calorie Supply|+|Crops;kcal/capita/day;;Amount of food available from crops and secondary products;M |
There was a problem hiding this comment.
Should be mapped to:
Food Availability|Crops [per capita];kcal/cap/day;1;Amount of food available from crops and secondary products;;Nutrition|Calorie Supply|+|Crops;kcal/capita/day;;;M;
Food Availability|Crops [per capita];kcal/cap/day;1;Amount of food available from crops and secondary products;;Nutrition|Calorie Supply|+|Secondary products;kcal/capita/day;;;M;
| Population|Poverty|Below 50% of National Median Income [Share];%;Population|Relative poverty|wrt median income|Share;percent;;Share of population below 50% of median national income;S | ||
| Population|Poverty|Extreme Poverty;million;Population|Extreme Poverty|International poverty line;million;;Number of people living in extreme poverty with income below USD_2017 2.15 PPP per day (World Bank definition);S | ||
| Population|Poverty|National Poverty Line [Share];%;;;;Share of population living in relative poverty with income below their respective national poverty lines; | ||
| Population|Prevalence of Normal Weight;million;Population;million;;Number of adults with body mass index (BMI) BMI between 18.5 and 25 and children with BMI within two standard deviations below reference (lower bound) and one standard deviations above reference (upper bound);M |
There was a problem hiding this comment.
Here, the correct mapping is (note the -1 in one of the last colums that defines the sign of the respective model variable):
Population|Prevalence of Normal Weight;million;;Number of adults with body mass index (BMI) BMI between 18.5 and 25 and children with BMI within two standard deviations below reference (lower bound) and one standard deviations above reference (upper bound);;Population;million;;;M;
Population|Prevalence of Normal Weight;million;;Number of adults with body mass index (BMI) BMI between 18.5 and 25 and children with BMI within two standard deviations below reference (lower bound) and one standard deviations above reference (upper bound);;SDG|SDG03|Prevalence of overweight;million;-1;;M;
Population|Prevalence of Normal Weight;million;;Number of adults with body mass index (BMI) BMI between 18.5 and 25 and children with BMI within two standard deviations below reference (lower bound) and one standard deviations above reference (upper bound);;SDG|SDG02|Prevalence of underweight;million;-1;;M;
There was a problem hiding this comment.
I think I found an issue in the ScenarioMIP mapping itself:
There should be an additional row that represents an additional substraction of ghe mode variable SDG|SDG03|Prevalence of obesity:
Population|Prevalence of Normal Weight;million;;Number of adults with body mass index (BMI) BMI between 18.5 and 25 and children with BMI within two standard deviations below reference (lower bound) and one standard deviations above reference (upper bound);;Population;million;;;M;
Population|Prevalence of Normal Weight;million;;Number of adults with body mass index (BMI) BMI between 18.5 and 25 and children with BMI within two standard deviations below reference (lower bound) and one standard deviations above reference (upper bound);;SDG|SDG03|Prevalence of obesity;million;-1;;M;
Population|Prevalence of Normal Weight;million;;Number of adults with body mass index (BMI) BMI between 18.5 and 25 and children with BMI within two standard deviations below reference (lower bound) and one standard deviations above reference (upper bound);;SDG|SDG03|Prevalence of overweight;million;-1;;M;
Population|Prevalence of Normal Weight;million;;Number of adults with body mass index (BMI) BMI between 18.5 and 25 and children with BMI within two standard deviations below reference (lower bound) and one standard deviations above reference (upper bound);;SDG|SDG02|Prevalence of underweight;million;-1;;M;
There was a problem hiding this comment.
Update: Florian already fixed this issue in the ScenarioMIP mapping (see PR554).
Purpose of this PR
Added SusMIP mapping file - for PRISMA
Checklist:
renamed_piam_variables.csvto guarantee backwards compatibility.|+|notation consistently. This can be achieved automatically withupdatePlusUnit().It is recommended to have a look at the tutorial before submission.