Calc output for UNFCCC non-annex-data - #841
Merged
Merged
Conversation
simonkrogmann
changed the title
simonkrogmann
force-pushed
the
unfccc-non-annex
branch
from
July 27, 2026 09:47
3fd6fa7 to
0d1d3d9
Compare
fbenke-pik
approved these changes
Jul 27, 2026
Contributor
|
For additional validation, make sure that your changes don't introduce new warnings and the resulting magpie object has the correct regions, years and additional variables. |
simonkrogmann
force-pushed
the
unfccc-non-annex
branch
from
July 27, 2026 12:56
0d1d3d9 to
c6415d0
Compare
fschreyer
requested changes
Jul 28, 2026
fschreyer
left a comment
fschreyer
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I realized that some variable names should be mapped differently. See comments below.
simonkrogmann
force-pushed
the
unfccc-non-annex
branch
2 times, most recently
from
July 28, 2026 14:53
48f4fb9 to
ce64a79
Compare
simonkrogmann
force-pushed
the
unfccc-non-annex
branch
from
July 28, 2026 15:58
ce64a79 to
cc1a5e9
Compare
fbenke-pik
reviewed
Jul 29, 2026
fbenke-pik
reviewed
Jul 31, 2026
| cells_and_regions = getISOlist(), | ||
| years = years, | ||
| names = names, | ||
| sets = c("region", "year", "value"), |
Contributor
There was a problem hiding this comment.
Calling the 3rd dimension will cause problems later on. Inputdata generation in fullVALIDATION crashes when appending the magpie object to historical.mif Just name the 3rd dimension variable as value is kinda reserved for the actual values.
"~ Argument 'value.name' should not overlap with column names in result: [Region, year, value]"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This maps the data read from non-annex-1 countries in pik-piam/mrcommonsenergy#13 to remind variables. I also added aggregate variables for the annex data to match the non-annex data.
Additionally, I modified the handling of subdimensions.