Bugfix: harmonize historical smoothed drivers (GDP, Pop) across scenarios - #63
Open
bennet21 wants to merge 8 commits into
Open
Bugfix: harmonize historical smoothed drivers (GDP, Pop) across scenarios#63bennet21 wants to merge 8 commits into
bennet21 wants to merge 8 commits into
Conversation
bennet21
marked this pull request as ready for review
July 5, 2026 08:59
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
reviewed
Jul 6, 2026
fbenke-pik
approved these changes
Jul 13, 2026
fbenke-pik
left a comment
fbenke-pik
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Everything looks good to me now.
JakobBD
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For improved model results, driver data (GDP, Pop, Floorspace) is smoothed. Previously, historical and future data was smoothed together. This leads to slightly different historical driver values across scenarios, which is not desired.
This PR fixes this with a new smoothing function:
toolHistoricallyConsistentSmoothing. It smoothes every scenario independently. Then, historical data for non reference scenarios (by default any scenario other than SSP2) is replaced by the historical smoothed data from the reference scenario (SSP2). Because this might lead to discontinuities on the historical/future interface in non reference scenarios a smooth transition between smoothed reference and smoothed future scenario is applied.The new tool function is tested separately. Let me know if this is good practice of if we prefer it differently.