Add neasted calling of withMadratLogging with different parameters and add warningsAsErrors parameter - #309
Open
tobiasdiez wants to merge 1 commit into
Open
Add neasted calling of withMadratLogging with different parameters and add warningsAsErrors parameter#309tobiasdiez wants to merge 1 commit into
withMadratLogging with different parameters and add warningsAsErrors parameter#309tobiasdiez wants to merge 1 commit into
Conversation
…and add `warningsAsErrors` parameter
Author
|
Running any idea what's the problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how withMadratLogging() behaves when calls are nested.
Previously, the first, outermost call installed the handlers. Every nested withMadratLogging() call then returned its expression immediately. As a result, its
logOnlyargument had no effect: all warnings and errors were handled according to the outermost call’s settings.With this PR, each withMadratLogging() call temporarily introduces its own policy with the following update mechanism:
Also this PR introduces a
warningsAsErrorsargument towithMadratLoggingso that warnings are logged as errors with the correct verbosity handling.