feat: flexible stock and initial stock - #125
Draft
JakobBD wants to merge 19 commits into
Draft
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… delete lapack solver for stock driven
JakobBD
marked this pull request as draft
November 13, 2025 08:30
10 tasks
for more information, see https://pre-commit.ci
Co-authored-by: JakobBD <44020564+JakobBD@users.noreply.github.com>
Co-authored-by: JakobBD <44020564+JakobBD@users.noreply.github.com>
Co-authored-by: JakobBD <44020564+JakobBD@users.noreply.github.com>
…sts-for-dsm-functionality
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This could be broken into two PR's, where f18d93a is the first commit of the second PR:
Flexible stock
Adds a
FlexibleDSMclass which uses either stock driven or inflow driven compute routine, depending on what you pass it.Deletes the lapack solver on the way.
TODO (apart from the usual):
Deleting the lapack solver is a break of backwards compatibility, which seems fine, as I doubt anyone is using it.
Initial stock
TODO (apart from the usual):
TODO generalpoints instocks.pyinline comments (copied here):(for inflow: only represents/replaces the newest cohort!)
Builds on #124, so that should be merged first
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
pyproject.tomlfile accordingly