Skip to content

Fix bug in config and update default input revision - #51

Merged
ricardarosemann merged 1 commit into
pik-piam:mainfrom
ricardarosemann:bugfix-config
May 27, 2026
Merged

Fix bug in config and update default input revision#51
ricardarosemann merged 1 commit into
pik-piam:mainfrom
ricardarosemann:bugfix-config

Conversation

@ricardarosemann

Copy link
Copy Markdown
Collaborator

Code changes

  • Fix bug in config for SSP3 scenario: Missing decimal point in some entries
  • Increase the default input revision, as the current code is not runnable with revision 0.5.11 and requires 0.5.12.

@hagento

hagento commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Isn't this exactly what I did in PR #50 last month? 😬

@ricardarosemann

Copy link
Copy Markdown
Collaborator Author

Isn't this exactly what I did in PR #50 last month? 😬

Sorry, I think I completely overlooked that one. I'll approve your PR then.

@ricardarosemann

Copy link
Copy Markdown
Collaborator Author

Actually, it's not exactly the same: There is still a similar error for SSP3 for parameters feShare_space/water_heating_petrol/biomod that you did not fix in your PR. My proposal would be to then actually merge my PR and close yours? Unless something is missing in my PR that is part of yours?

@hagento hagento left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah perfect, not only did I overlook that one but that would hopefully also solve the weird results I get in my REMIND SSP3 runs. Let's merge yours and close mine then.

@hagento

hagento commented May 27, 2026

Copy link
Copy Markdown
Collaborator

After merging, I would run a full run and update sources/EdgeBuildings/2.9.

@ricardarosemann
ricardarosemann merged commit ed70a2f into pik-piam:main May 27, 2026
1 check passed
@ricardarosemann
ricardarosemann deleted the bugfix-config branch May 27, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants