feat(pgs): forward etag and last-modified headers from imgproxy #179
+76
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR in addition to #178 complete the implementation of conditional requests (#177).
ServeObject
functionServeObject
now returns anObjectInfo
struct so that we can inspect last-modified and etag headers coming from Minio/imgproxyThe result is that requests for images that flow through imgproxy will have the same etag and last-modified headers as files that we pull directly from minio. Example:
(yes the etags in this example are missing quotes and the date is in the wrong timezone, two bugs which are fixed in #178)