Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Accounts Kotlin library as default endpoint provider #56

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

kp-said-rehouni
Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni commented Aug 15, 2024

Summary
This PR sets the account Kotlin library as the default endpoint provider. The account implementation based on the new networking engine remains in the code but it's not used.

@kp-said-rehouni kp-said-rehouni changed the title Add vpn token fallback [DO NOT MERGE] Add vpn token fallback Aug 15, 2024
@kp-said-rehouni kp-said-rehouni force-pushed the KM-0000_hotfix_revert_accounts_migration branch 2 times, most recently from 2b293f1 to f8e787c Compare August 15, 2024 12:18
Copy link
Collaborator

@kp-laura-sempere kp-laura-sempere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kp-said-rehouni for the fixes!

@kp-said-rehouni kp-said-rehouni force-pushed the KM-0000_hotfix_revert_accounts_migration branch from f8e787c to 88f113a Compare August 29, 2024 11:40
@kp-said-rehouni kp-said-rehouni force-pushed the KM-0000_hotfix_revert_accounts_migration branch from 88f113a to a5a0726 Compare August 29, 2024 12:24
@kp-said-rehouni kp-said-rehouni marked this pull request as ready for review August 29, 2024 12:32
@kp-said-rehouni kp-said-rehouni changed the title [DO NOT MERGE] Add vpn token fallback Set Accounts Kotlin library as default endpoint provider Aug 29, 2024
Copy link
Collaborator

@kp-laura-sempere kp-laura-sempere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good
Thank you @kp-said-rehouni

@kp-said-rehouni kp-said-rehouni merged commit 1a52024 into master Aug 29, 2024
1 check passed
@kp-said-rehouni kp-said-rehouni deleted the KM-0000_hotfix_revert_accounts_migration branch August 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants