Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update command for v6 #3299

Closed
wants to merge 1 commit into from
Closed

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Mar 8, 2025

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@XhmikosR XhmikosR marked this pull request as ready for review March 8, 2025 17:03
@dschaper
Copy link
Member

dschaper commented Mar 8, 2025

This depends on the user running the command really. Does the Debian documentation call out that you have to run apt update with sudo apt update?

Oh, and since the template wasn't filled out and the PR description doesn't say anything useful, this PR simply prepends the word sudo to the instructions to use pihole -up to update.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Mar 8, 2025

I just saw pi-hole/pi-hole#6066 and thought I'd submit a PR with the change, but feel free to close.

I know that for me at least, it needs sudo to run pihole -up in v6.

@mwoolweaver
Copy link

Worth noting is that sudo is given in the forgotten password instructions on the login page. Having some consistency in how to use the pihole command would be appreciated by some user, not necessarily me as retrying with sudo isn't hard and is also suggested if using without sudo.

Screenshot_20250308-202738

@rdwebdesign
Copy link
Member

Maybe we could create a documentation page similar to this one explaining how to add users to pihole group.

docker command needs sudo if executed by non-root user, but you won't see every reference in docker docs using sudo docker.

@PromoFaux
Copy link
Member

explaining how to add users to pihole group.

Hmmm, thinking more about this - would a user being in the pihole group necessarily work here? last I checked the local repos were root owned so it wouldn't make much difference.

image

Ultimately I think this is a bit of a non-issue. We transparently elevated to sudo in v5, and in most cases users would have been prompted for their sudo password at that point - however I think by default the raspberry pi is configured for passwordless sudo...

Either way, it's fairly self documented. As I mentioned in my comment on pi-hole/pi-hole#6070 (comment) - Other services may not even be as helpful as suggesting to rerun the command with sudo

@rdwebdesign
Copy link
Member

Ultimately I think this is a bit of a non-issue ...
... Either way, it's fairly self documented ...
... Other services may not even be as helpful as suggesting to rerun the command with sudo

I agree.

@XhmikosR
Copy link
Contributor Author

Then I'd say maybe just drop sudo from other cases in the Web interface to be consistent, but it's your call.

@XhmikosR XhmikosR closed this Mar 20, 2025
@XhmikosR XhmikosR deleted the patch-2 branch March 20, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants