Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no responseJSON coming back from POSTs/xhrs #3273

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

bobrippling
Copy link

What does this PR aim to accomplish?:

This resolves issues with frontend JS when the server fails to send a responseJSON reply, leaving the frontend hanging in a "loading" state.

This also resolve these console errors:

Uncaught TypeError: xhr.responseJSON is undefined
    <anonymous> https://<host>/admin/scripts/js/login.js?v=0:171
    jQuery 6
    <anonymous> https://<host>/admin/scripts/js/login.js?v=0:163
    jQuery 13

Uncaught TypeError: right-hand side of 'in' should be an object, got undefined
    wrongPassword https://<host>/admin/scripts/js/login.js?v=0:33
    doLogin https://<host>/admin/scripts/js/login.js?v=0:105
    jQuery 6
    doLogin https://<host>/admin/scripts/js/login.js?v=0:91
    <anonymous> https://<host>/admin/scripts/js/login.js?v=0:122
    jQuery 9
    <anonymous> https://<host>/admin/scripts/js/login.js?v=0:111

How does this PR accomplish the above?:

We confirm that responseJSON exists in the response object before accessing into it.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@bobrippling bobrippling force-pushed the fix/response-json branch 2 times, most recently from bee9387 to af7b182 Compare March 3, 2025 20:14
@bobrippling bobrippling force-pushed the fix/response-json branch 4 times, most recently from be65ac2 to eba3dfc Compare March 3, 2025 20:19
@bobrippling
Copy link
Author

bobrippling commented Mar 3, 2025

Can't get round the linter - it complains about either eqeqeq or no-eq-null

Removed those changes, left it at responseJSON

@yubiuser yubiuser requested a review from rdwebdesign March 3, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants