-
Notifications
You must be signed in to change notification settings - Fork 4
Kill agents #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Kill agents #341
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 82.65% 82.05% -0.61%
==========================================
Files 36 36
Lines 5472 5467 -5
Branches 533 530 -3
==========================================
- Hits 4523 4486 -37
- Misses 949 981 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /// An agent will be considered stagnant if it has not moved for timeToleranceFactor * std::ceil(street_length / street_maxSpeed) time units. | ||
| /// @param timeToleranceFactor The time tolerance factor | ||
| /// @throw std::invalid_argument If the time tolerance factor is not positive | ||
| void killStagnantAgents(double timeToleranceFactor = 3.); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.8 rule Note
| /// An agent will be considered stagnant if it has not moved for timeToleranceFactor * std::ceil(street_length / street_maxSpeed) time units. | ||
| /// @param timeToleranceFactor The time tolerance factor | ||
| /// @throw std::invalid_argument If the time tolerance factor is not positive | ||
| void killStagnantAgents(double timeToleranceFactor = 3.); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 13.4 rule Note
| bool overtimed{false}; | ||
| { | ||
|
|
||
| if (m_timeToleranceFactor.has_value()) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 14.4 rule Note
|
I still don't know if it is worth to implement this... if the simulation is well-written you must not kill vwhicles to avoid gridlocks. |
TODO: