Skip to content

Conversation

@Grufoony
Copy link
Collaborator

@Grufoony Grufoony commented Oct 6, 2025

TODO:

  • Add tests for the new code

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.05%. Comparing base (721c0ff) to head (13497b6).

Files with missing lines Patch % Lines
src/dsf/headers/RoadDynamics.hpp 25.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   82.65%   82.05%   -0.61%     
==========================================
  Files          36       36              
  Lines        5472     5467       -5     
  Branches      533      530       -3     
==========================================
- Hits         4523     4486      -37     
- Misses        949      981      +32     
Flag Coverage Δ
unittests 82.05% <25.00%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

/// An agent will be considered stagnant if it has not moved for timeToleranceFactor * std::ceil(street_length / street_maxSpeed) time units.
/// @param timeToleranceFactor The time tolerance factor
/// @throw std::invalid_argument If the time tolerance factor is not positive
void killStagnantAgents(double timeToleranceFactor = 3.);

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 17.8 rule Note

MISRA 17.8 rule
/// An agent will be considered stagnant if it has not moved for timeToleranceFactor * std::ceil(street_length / street_maxSpeed) time units.
/// @param timeToleranceFactor The time tolerance factor
/// @throw std::invalid_argument If the time tolerance factor is not positive
void killStagnantAgents(double timeToleranceFactor = 3.);

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 13.4 rule Note

MISRA 13.4 rule
bool overtimed{false};
{

if (m_timeToleranceFactor.has_value()) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 14.4 rule Note

MISRA 14.4 rule
@Grufoony
Copy link
Collaborator Author

I still don't know if it is worth to implement this... if the simulation is well-written you must not kill vwhicles to avoid gridlocks.
Need to think about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant