test(contracts): add state oracle v2 fuzz and edge coverage - #47
Open
fredo wants to merge 1 commit into
Conversation
Contributor
Author
|
Known inherited CI blocker: the shared workflow builds |
mateo-mro
reviewed
Aug 12, 2026
| } | ||
|
|
||
| function test_eachOperationalRoleIsRejectedFromEveryOtherRoleCapability() public { | ||
| address[5] memory actors = [GOVERNANCE, GUARDIAN, PROJECT_CREATOR, PROJECT_ADMIN, TRIGGER_LIMITER]; |
There was a problem hiding this comment.
Guardian Admin is missing from this matrix. The hierarchy test proves it can manage Guardian membership and not default administered roles, but it never proves that holder cannot pause, create projects, change limits, recover projects, or take Guardian actions. ENG 4251 calls for every operational role to be isolated, so can we include it here as a sixth actor?
fredo
force-pushed
the
frederik/eng-4251-testcontracts-add-v2-fuzz-edge-coverage
branch
from
August 12, 2026 11:05
bd52fc3 to
a54a146
Compare
fredo
force-pushed
the
frederik/eng-4229-fixcontracts-scope-executor-event-guard-by-key
branch
from
August 12, 2026 11:05
78862b5 to
079196e
Compare
fredo
marked this pull request as ready for review
August 12, 2026 11:14
fredo
requested review from
makemake-kbo,
odyslam and
penumbra23
as code owners
August 12, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses ENG-4251.
Adds focused fuzz and edge coverage for assignments, bounds, role isolation, recovery, retirement, reinstallation, and trigger-unit conservation.