Allow opting out of new routing algorithm via a flag #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
CamJN
force-pushed
the
bugfix/make_new_routing_optional
branch
from
90e4797 to
0a11528
Compare
CamJN
changed the title
FooBarWidget
requested changes
Jan 31, 2025
| @@ -202,6 +200,8 @@ class Group: public boost::enable_shared_from_this<Group> { | |||
| Callback shutdownCallback; | |||
| GroupPtr selfPointer; | |||
|
|
|||
| // Whether to use the old routing algorithm | |||
| bool oldRouting; | |||
There was a problem hiding this comment.
Since on the web server level this is a global config anyway, you can turn this into a pool-level flag (i.e., a boolean in ApplicationPool2::Context) instead of a Group-level flag. That simplifies some code.
CamJN
force-pushed
the
bugfix/make_new_routing_optional
branch
from
484f843 to
eaf3953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #2579 we decided to make the new routing optional. One option was to only use the new routing when rolling restarting, but there isn't a good way to check if that is going on as far as I can tell. So in order to do this quickly, I am just adding a flag. I don't expect this to be a very commonly needed setting.
If there is a better way to check for rolling restarts, I can easily change the implementation of
useNewRouting.