Prevent unnecessary work in NodeScopeResolver->processAssignVar() #4705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This pull request has been marked as ready for review. |
staabm
commented
Jan 3, 2026
| $conditionalExpressions = $this->processSureTypesForConditionalExpressionsAfterAssign($scope, $var->name, $conditionalExpressions, $falseySpecifiedTypes, $falseyType); | ||
| $conditionalExpressions = $this->processSureNotTypesForConditionalExpressionsAfterAssign($scope, $var->name, $conditionalExpressions, $falseySpecifiedTypes, $falseyType); | ||
|
|
||
| if ($truthyType !== $type) { |
Contributor
Author
There was a problem hiding this comment.
when $truthyType = TypeCombinator::removeFalsey($type); returns $truthyType === $type, this means TypeCombinator::intersect($type, StaticTypeFactory::falsey()) will always be a NeverType.
Contributor
Author
There was a problem hiding this comment.
blackfire reports 10.000 less invocations of TypeCombinator::intersect with this PR in comparison to 2.1.x@c53546e53a on bin/phpstan analyse src/Analyser/ src/Rules/ -v --debug
Member
|
Very very nice! Looking forward to what you find next :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents unnecessary work when e.g. assigning variables to non-falsy values.
to my suprise this hardly has an influence on performance, even though I can see
if ($truthyType !== $type) {is not alwaystrue.