Skip to content

Fix PDOStatement getIterator stub type #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 2.1.x
Choose a base branch
from
Open

Fix PDOStatement getIterator stub type #3974

wants to merge 6 commits into from
+18 −0

Conversation

mbolli
Copy link

@mbolli mbolli commented Apr 30, 2025 •
edited
Loading

staabm
staabm suggested changes Apr 30, 2025
View reviewed changes
@mbolli
Copy link
Author

mbolli commented Apr 30, 2025

@staabm thanks for the // lint hint. not sure about the 2 failing tests, but I'll mark this as ready for review.

@mbolli mbolli marked this pull request as ready for review April 30, 2025 11:29
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@mbolli mbolli requested a review from staabm May 1, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PHP 8] PDOStatement::getIterator: returned value detected as Traverable and not Iterator
3 participants
@mbolli @phpstan-bot @staabm