Fix error when displaying Milestone details#43
Open
PaulAndrews wants to merge 1 commit intophpfreak:masterfrom
Open
Fix error when displaying Milestone details#43PaulAndrews wants to merge 1 commit intophpfreak:masterfrom
PaulAndrews wants to merge 1 commit intophpfreak:masterfrom
Conversation
Code would result in error when canEdit=False, as getMilestoneID was being referenced instead of getMilestone. Also, a lang() construct was used around the Milestone's name. As language strings can't be set by the user (and the Milestone name when elsewhere isn't treated like this) I replaced this with clean().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code would result in error when canEdit=False, as getMilestoneID was being referenced instead of getMilestone.
Also, a lang() construct was used around the Milestone's name. As language strings can't be set by the user (and the Milestone name when elsewhere isn't treated like this) I replaced this with clean().