Always check for references when running node:remove #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
remove-node-check-references
branch
from
f751f70 to
436db04
Compare
|
this could be a bit confusing. there are weak references that do not prevent deleting, and the jcr 1.0 references (we sometimes speak of "hard references"). this PR is only about hard references as far as i can tell - which is the correct thing. i would refine the wording in the changelog and exception. and maybe add a test to show that leaving a dangling weak reference works. |
|
good point, will update. |
dantleech
force-pushed
the
remove-node-check-references
branch
from
436db04 to
369abf6
Compare
|
updatred. |
dantleech
force-pushed
the
remove-node-check-references
branch
from
369abf6 to
4edb11e
Compare
- Help prevent transaction failure when calling save - Also allow the removal of node by UUID
dantleech
force-pushed
the
remove-node-check-references
branch
from
4edb11e to
ed9b95b
Compare
dantleech
added a commit
that referenced
this pull request
Dec 21, 2014
Always check for references when running node:remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #107