Skip to content

Enable sphinx-multiversion #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 14, 2021
Merged

Enable sphinx-multiversion #227

merged 8 commits into from
Apr 14, 2021

Conversation

marc1706
Copy link
Member

Also backported the new styling

Fixes #226

@iMattPro
Copy link
Member

Screenshots?

@marc1706
Copy link
Member Author

Default view:
image
Expanded version picker:
image

I'd say looks the same 👍

@marc1706
Copy link
Member Author

Unfortunately, the master files are only in the subfolders and not in the root of the build folder. I think I'll have to add another index.html that just redirects to the main subfolder ...


.rst-versions.shift-up {
overflow: auto;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this CSS be from the other PR, it also seems a little different than in the other PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same CSS as before the table changes. I don't think it makes a lot of sense to port these to 3.2.x. Merging into 3.3.x and above, this should be resolved. The only addition is the rule for .rst-versions.shift-up.

The rtd theme does not support this anyway.
@marc1706 marc1706 merged commit 8967b02 into 3.2.x Apr 14, 2021
@marc1706 marc1706 deleted the ticket/226 branch April 14, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants