Repository navigation
zend_test: Fix function and constant imports in compile_to_ast and add support for grouping - #24418
Open
mainframe98 wants to merge 1 commit into
Open
mainframe98 wants to merge 1 commit into
mainframe98 wants to merge 1 commit into
Conversation
mainframe98
force-pushed
the
zend-test-compile-to-ast-grouped-use-support
branch
from
October 19, 2026 17:21
29baf1b to
c4c298b
Compare
Member
|
So this is actually a bugfix, but your PR title doesn't imply that. |
mainframe98
force-pushed
the
zend-test-compile-to-ast-grouped-use-support
branch
from
October 20, 2026 17:15
c4c298b to
782d13d
Compare
…d support for grouping While writing a test for it, I discovered the logic for printing the AST representation of use statements was broken and grouping did not work. That has been fixed and incorporated into the test.
mainframe98
force-pushed
the
zend-test-compile-to-ast-grouped-use-support
branch
from
October 20, 2026 17:18
782d13d to
56214fb
Compare
mainframe98
changed the title
Author
I wasn't sure if |
Author
|
I wasn't aware that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing a test for it, I discovered the logic for printing
the AST representation of use statements was broken and grouping
did not work. That has been fixed and incorporated into the test.