standard: Avoid double hash table lookup in iptcparse() #20420
Closed
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
reviewed
Nov 8, 2025
Zend/zend_hash.c
Outdated
| return _zend_hash_str_add_or_update_i(ht, str, len, h, pData, HASH_ADD_NEW); | ||
| } | ||
|
|
||
| ZEND_API zval* ZEND_FASTCALL zend_hash_str_add_lookup(HashTable *ht, const char *str, size_t len) |
Member
There was a problem hiding this comment.
Suggested change
| ZEND_API zval* ZEND_FASTCALL zend_hash_str_add_lookup(HashTable *ht, const char *str, size_t len) | |
| ZEND_API zval* ZEND_FASTCALL zend_hash_str_lookup(HashTable *ht, const char *str, size_t len) |
For consistency with zend_hash_lookup(), zend_hash_index_lookup(). _lookup already implies _add.
Member
Author
There was a problem hiding this comment.
Right, that's what I meant. Probably not a good idea to make commits at midnight ;)
arnaud-lb
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.