ODBC fetch refactoring #19848
Open
ODBC fetch refactoring #19848
+84
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ARM failure unrelated. FWIW, if this misses 8.5, I'll probably continue some further refactoring in this PR. |
Now that we can assume fetch_hash exists, there's a lot of redundancy in these functions. Merge their implementations, and smooth over the differences in how they handle returning their result set as an array.
These are also doing extremely similar jobs, but with slightly different behaviours for the return value (in this case, none, as it's tended to be used with odbc_result). Unify this too. The $row value deprecation for 0/-1 is only handled for odbc_fetch_row; it's too late to do so for PHP 8.5. Should probably unify it for PHP 8.6.
Since this is a much more shared fetch function now.
NattyNarwhal
force-pushed
the
odbc-fetch-cleanup
branch
from
9a15b54 to
770ce9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php_odbc_fetch_intointophp_odbc_fetch_hash.odbc_fetch_intois kind of weird. I don't know if it'd be better to deprecate it and have a more "symmetrical" API that works likeodbc_fetch_array.php_odbc_fetch_hashto use ZPP.SQLExtendedFetchcalls toSQLFetchScrollSQLExtendedFetchwithSQLFetchScrollin ext/odbc #19522.php_odbc_fetch_rowintophp_odbc_fetch_hashfetch_into, though with special $row == 0/-1 deprecation (see Make ext/odbc default value handling more consistent #13910)