Streams Poll API #19572
Open
Streams Poll API #19572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Build System
SAPI: fpm
Extension: standard
ABI break
labels
|
Currently just kqueue and poll on MacOS are properly tested. The epoll should be easy to get tested but will need to then properly look to iocp and event ports. For event ports I will need to first set OmniOS (Illumos) up. |
|
So epoll looks good and all tests passing there. Tha API also builds on Windows but unsuprisingly the iocp backend does not really work well so this is someting that I will be looking to. And then event ports will likely need some work as well which I will look then too. |
bukka
force-pushed
the
poll_api
branch
3 times, most recently
from
2d53464 to
4edefc1
Compare
It is to ignore invalid FDs
they match kqueue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new API for polling that supports various backends:
The API tries to reflect primarily epoll and the rest is done in a way so it is compatible.
RFC: https://wiki.php.net/rfc/poll_api