zend_hrtime: Check posix clock once and prefer CLOCK_MONOTONIC_RAW #19221
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-mabe
commented
Jul 23, 2025
Zend/zend_hrtime.c
Outdated
| return; | ||
| } | ||
|
|
||
| ZEND_ASSERT(0 && "No working CLOCK_MONOTONIC* found, this should never happen"); |
There was a problem hiding this comment.
How can I trigger a startup error here?
There was a problem hiding this comment.
mh 🤔 this ends up in a segfault at *filename = ZSTR_KNOWN(ZEND_STR_UNKNOWN_CAPITALIZED); I guess because zend_startup_hrtime gets called before initialization of the error mechanism.
Using zend_error_noreturn(E_CORE_ERROR, "No working CLOCK_MONOTONIC* found, this should never happen");
There was a problem hiding this comment.
Sigh. That makes sense. In that case an fprintf(stderr, "message\n"); abort(); sequence may be better...
marc-mabe
force-pushed
the
hrtime_posix_check_once
branch
from
dcd5a89 to
bee086b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19210.
This will test the support of the monotonic timer only once at startup.
Additionally it will prefer
CLOCK_MONOTONiC_RAW(if available) to not be affected by the incremental adjustments performed by adjtime(3) and NTP.