refactor: clean zend_get_brk_cont_target arguments and sync var types #19117
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Jul 14, 2025
| int array_offset = opline->op1.num; | ||
| static uint32_t zend_get_brk_cont_target(const zend_op *opline) { | ||
| uint32_t nest_levels = opline->op2.num; | ||
| uint32_t array_offset = opline->op1.num; |
There was a problem hiding this comment.
Technically should be fine, but we use int and even zend_long in other places (e.g. zend_compile_break_continue(), CG(context).current_brk_cont, etc.). If this needs to be adjusted, all of them should be.
|
Side-note:
Your branch-name seems to be messed up. |
|
@xepozz Can you revert the type change so we can merge the dropping of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.