Skip to content

ext/sockets: multicast on unsupported socket type error change. #19114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

From a mere warning to an exception.

@devnexen devnexen marked this pull request as ready for review July 13, 2025 06:53
@@ -137,8 +137,7 @@ int php_set_inet46_addr(php_sockaddr_storage *ss, socklen_t *ss_len, zend_string
}
#endif
else {
php_error_docref(NULL, E_WARNING,
"IP address used in the context of an unexpected type of socket");
zend_type_error("IP address used in the context of an unexpected type of socket");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really type error? Isn't it more a value error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.. I guess I took the type meaning a bit too far here

@devnexen devnexen force-pushed the inet46_toexception branch from 8b61219 to 79884f9 Compare July 15, 2025 11:49
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like really a user error in this case so conversion makes sense to me.

@devnexen devnexen closed this in 64852b4 Jul 15, 2025
TimWolla added a commit that referenced this pull request Jul 15, 2025
This did not make the cut for Alpha 2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants