ext/sockets: multicast on unsupported socket type error change. #19114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
reviewed
Jul 15, 2025
ext/sockets/sockaddr_conv.c
Outdated
| @@ -137,8 +137,7 @@ int php_set_inet46_addr(php_sockaddr_storage *ss, socklen_t *ss_len, zend_string | |||
| } | |||
| #endif | |||
| else { | |||
| php_error_docref(NULL, E_WARNING, | |||
| "IP address used in the context of an unexpected type of socket"); | |||
| zend_type_error("IP address used in the context of an unexpected type of socket"); | |||
There was a problem hiding this comment.
Is this really type error? Isn't it more a value error?
There was a problem hiding this comment.
yeah.. I guess I took the type meaning a bit too far here
From a mere warning to an exception.
devnexen
force-pushed
the
inet46_toexception
branch
from
8b61219 to
79884f9
Compare
bukka
approved these changes
Jul 15, 2025
TimWolla
added a commit
that referenced
this pull request
Jul 15, 2025
This did not make the cut for Alpha 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a mere warning to an exception.