ext/tidy: using tidyParseString when available instead for tidy::pars… #19093
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
tidy_parse_string_upd
branch
from
265f1f4 to
729b8d7
Compare
mvorisek
reviewed
Jul 11, 2025
| @@ -809,9 +807,15 @@ static zend_result php_tidy_parse_string(PHPTidyObj *obj, const char *string, ui | |||
|
|
|||
| obj->ptdoc->initialized = true; | |||
|
|
|||
| #ifdef HAVE_TIDYPARSESTRING | |||
| if (tidyParseString(obj->ptdoc->doc, string) < 0) { | |||
There was a problem hiding this comment.
https://3v4l.org/KMN1s (edit the repro slightly, as tidy ext is available for live/wasm preview only)
I guess this will stop parsing on the first null byte. Currently explicit length is honored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eString().